Ticket #14836 (closed bug: fixed)
Css -webkit-transistion, transition not set under Chrome
Reported by: | nathan.patry@… | Owned by: | m_gol |
---|---|---|---|
Priority: | high | Milestone: | 2.1.1 |
Component: | css | Version: | 2.1.0 |
Keywords: | Cc: | ||
Blocking: | Blocked by: |
Description
When setting transition using a litteral object such as :
var style = { "-webkit-transition": "-webkit-transform 1200ms ease", "transition": "transform 1200ms ease" }; $('#test').css(style);
And animating it, with a transformation such as :
var rotation = { "-webkit-transform": "rotate3d(0, 1, 0, 45deg)", "transform": "rotate3d(0, 1, 0, 45deg)" } $('#test').css(style).css(rotation);
The animation actually occurs under Firefox (v. 27.0.1), but there is no animation (but the div is correctly rotated) under Chrome (version 33.0.1750.117 m).
See a JSFiddle example here.
It worked with jQuery 2.0.3, but I can't tell for further versions.
Change History
comment:2 Changed 9 months ago by nathan.patry@…
I made a mistake, the problem occurs on jQuery 2.1.0, not 1.11
comment:3 Changed 9 months ago by dmethvin
- Priority changed from undecided to high
- Status changed from new to open
- Version changed from 1.11.0-rc1 to 2.1.0
- Component changed from unfiled to css
- Milestone changed from None to 2.1.1
It seems like transform doesn't work but all does: http://jsfiddle.net/dmethvin/7F9zR/5/
Something definitely changed though, it used to work: http://jsfiddle.net/dmethvin/7F9zR/6/
BTW, Chrome no longer requires prefixing, but caniuse.com says it does. That may be a clue? Maybe our auto-prefix algorithm is doing something wrong. http://caniuse.com/#search=transform http://jsfiddle.net/dmethvin/7F9zR/4/
comment:4 Changed 9 months ago by m_gol
- Owner set to m_gol
- Status changed from open to assigned
Chrome doesn't require prefixing transition but does require prefixing transform. I'll look into that.
comment:5 Changed 9 months ago by m_gol
OK, it'll be a hard one. Normally, the operation goes as follows:
- The "-webkit-transition": "-webkit-transform 1200ms ease" rule gets set normally
- The "transition": "transform 1200ms ease" rule gets applied twice: first prefixed as "-webkit-transition": "transform 1200ms ease" and then unprefixed. In both those cases the rule gets discarded by Chrome via the regular CSS cascade as Chrome doesn't recognize unprefixed transform.
This commit:
https://github.com/jquery/jquery/commit/24e587929f62428e1959b10aace6dc4fd65ab397
introduced resetting the style property to an empty string before setting it to the final value. Unfortunately, this makes the above mechanism to fail.
comment:6 Changed 9 months ago by m_gol
We could check if the style is not empty after assigning; then it means the browser didn't accept the rule and we should fall back to the previous one.
PR incoming.
comment:8 Changed 9 months ago by Michał Gołębiowski
- Status changed from assigned to closed
- Resolution set to fixed
Css: Revert 24e587929f62428e1959b10aace6dc4fd65ab397
The workaround to be able to change !important styles broke the browser keeping the old CSS value if the new one was rejected. Patching it would involve a significant perf hit (~33%) so the initial patch needs to be reverted instead.
Tests by m_gol & gibson042.
Fixes #14836 Closes gh-1532
Changeset: 2c180ef938201f1213b5c43c8212856d0282e1f0
The actual jQuery version is 2.1.0