Menus Office Hours (Feb 7)
Here’s a recap of yesterdays office hours.
Work accomplished since last office hours
- jkudish moved the theme location options to checkboxes for us to test
- I added accordion styling to menu items (for testing)
- We tested 2 new users with these changes (and they both performed the scenarios flawlessly)
- DrewAPicture implemented locations in the ‘Selected menu’ drop down
Major items discussed
1) Theme locations continues to be our biggest design challenge. We discussed a bunch of options and decided to go with checkboxes for theme locations for now – while we continue to stew on alternative approaches.
2) We discussed having settings at the top or the bottom, and settled on them being on the bottom.
On the docket
- Refactor accordion code (@lessbloat)
- Re-assess CSS in latest patch (currently 23119.28.1.diff), and move colors to colors.css (Looking for a volunteer here)
- Browser compat testing (Looking for a volunteer here)
- No JS testing (Looking for a volunteer here)
- Code review (Looking for volunteers here – hopefully from multiple people)
- Commit what we’ve got
After that
- Any additional accessibility work
- Additional code refactoring
- Am I missing anything?
p.s. @DrewAPicture, I added a title this time just for you.
Drew Jaynes (DrewAPicture) 5:57 pm on February 8, 2013 Permalink | Log in to Reply
RE: title, “He can be taught!”
We also need to do an extensive round of RTL testing as well as completing docblocks for any new functions we’re introducing, @access private or not.
I can start on no-js testing this weekend.
lessbloat 6:05 pm on February 8, 2013 Permalink | Log in to Reply
I did a round of RTl testing/fixing (I’m not sure I would call it extensive, but I think I caught most everything).
Awesome! Thanks for that.
Drew Jaynes (DrewAPicture) 10:06 pm on February 8, 2013 Permalink | Log in to Reply
I also added more complete docblocks to new functions in 23119.28.2.diff
sireneweb 4:50 pm on February 11, 2013 Permalink | Log in to Reply
Hi, very nice![:)](https://webarchive.library.unt.edu/web/20130212194653im_/http://make.wordpress.org/core/wp-includes/images/smilies/icon_smile.gif)
When you use Mega drop down menu, you can’t delete all children from main menu. It would be great if we can Expand/Collaspe main menu and delete all children sub menu from main menu
lessbloat 6:14 pm on February 11, 2013 Permalink | Log in to Reply
I asked @jkudish to gather some data around avg number of menu items per menu for sites on WP.com. Out of 1000 random sites (with at least one menu added), here’s what the distribution looked like:
Excluding the menus with zero items added, the average comes out to 5.
So, based on this data, should we make some sort of expand/collaspe menu item functionality a part of core, or keep it in plugin territory?
I think my preference would be to keep it as a plugin, but I’d love to hear everyones thoughts.
Joey Kudish 7:04 pm on February 11, 2013 Permalink | Log in to Reply
Just a small correction to the description above, it was 3000 sites, not 1000. A lot of them didn’t have any menus at all, which is why if you add up the above numbers you don’t get 3000
Joey Kudish 7:05 pm on February 11, 2013 Permalink | Log in to Reply
Also, I agree with @lessbloat, I think this is plugin territory.