Ticket #15734 (closed enhancement: fixed)

Opened 2 years ago

Last modified 5 months ago

Add soundcloud.com oEmbed support

Reported by: ericwahlforss Owned by: markjaquith
Priority: normal Milestone: 3.5
Component: Embeds Version:
Severity: normal Keywords: has-patch
Cc:

Description

SoundCloud is the most popular site for audio/music sharing. It's to sound what Flickr is to photos and Youtube is to video. It has had oEmbed support for over a year now, would be great to support as many music bloggers are using WP+SoundCloud.

Attachments

15734.patch (797 bytes) - added by ericwahlforss 2 years ago.
update oembed class to support soundcloud
add-oembed-providers.diff (968 bytes) - added by wonderboymusic 6 months ago.

Change History

update oembed class to support soundcloud

  • Status changed from new to closed
  • Resolution set to maybelater
  • Milestone Awaiting Review deleted

This is best in a plugin for now

  • Status changed from closed to reopened
  • Resolution maybelater deleted

Add Soundcloud and Kickstarter - I seriously doubt Funny or Die is widely embedded and it is a default provider. Attached a new patch.

  • Milestone set to Awaiting Review
  • Milestone changed from Awaiting Review to 3.5
  • Owner set to markjaquith
  • Status changed from reopened to assigned

Asking Mark to make a determination for this.

Could we add support for sound cloud short code as well : http://snd.sc/RuMhzl

Per an IRC dev chat, soundcloud.com is good to go if the oEmbed endpoint checks out.

soundcloud.com has a weird thing with their endpoint. They pass a width of 100% by default, which is against the spec (supposed to be pixels), but the moment you pass a maxwidth (which we always do), it uses that value instead. So we're good. Just a little quirk.

  • Status changed from assigned to closed
  • Resolution set to fixed

In [22003]:

Add soundcloud and slideshare to the oEmbed providers list. props bradparbs, ericwahlforss, wonderboymusic. fixes #15734, #21635.

Note: See TracTickets for help on using tickets.