Ticket #20102 (closed enhancement: fixed)
https oEmbed
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | normal | Milestone: | 3.5 |
| Component: | Embeds | Version: | 3.3.1 |
| Severity: | normal | Keywords: | has-patch commit |
| Cc: | georgemamadashvili@…, yoavf, jeremy@…, simon@… |
Description
The new version of vimeo.com uses https urls, which currently do not trigger WordPress's oEmbed embedding.
Attachments
Change History
- Milestone changed from 3.4 to Awaiting Review
Same problem as with YouTube https embed, see #18719.
I feel like oEmbed in WordPress should automatically handle https links for all providers, including those that are not regular expressions (http://example.com/*).
johnjamesjacoby — 6 months ago
- Attachment vimeo-oembed-https.2.diff added
Patch was stale. Refreshed for whitespace. (wcgr)
Applied JJJ's patch, works! Rock on WCGR! Props JJJ and Mark Jaquith!
comment:10
Tyrun — 6 months ago
Applied JJJ's patch as well and it works. Thanks for showing us how @ WCGR!
johnjamesjacoby — 6 months ago
- Attachment vimeo-oembed-https.3.diff added
Massaged to handle https/http for all providers
vimeo-oembed-https.3.diff updates all the regular expressions to handle https. Updates the simple URL processor to handle https in the regular expression it generates. Props WCGR.
johnjamesjacoby — 6 months ago
- Attachment vimeo-oembed-https.4.diff added
Cleans up version 3 logic (wcgr)
comment:13
simonwheatley — 5 months ago
- Cc simon@… added
Always nice to see someone has already created the patch you were about to create. :)
comment:15
ryan — 5 months ago
- Owner set to ryan
- Status changed from new to closed
- Resolution set to fixed
In [21915]:
