Security Enhanced Linux
What's New
Frequently Asked Questions
Background
Documents
License
Download
Participating
Mail List
Archives
Remaining Work
Contributors
Related Work
Press Releases
Information Assurance Research
NIARL In-house Research Areas
Mathematical Sciences Program
Sabbaticals
Computer & Information Sciences Research
Technology Transfer
Advanced Computing
Advanced Mathematics
Communications & Networking
Information Processing
Microelectronics
Other Technologies
Technology Fact Sheets
Publications
Related Links
|
SELinux Mailing ListRe: This policy causes checkmodule to segfault.
From: Joshua Brindle <method_at_manicmethod.com>
Date: Sun, 16 Nov 2008 18:58:57 -0500
Well, this doesn't look good. There are a couple issues here. The first is that when we changed the symtab_insert behavior to allow require then declare we missed the alias case, the patch below should fix that. The second problem is that type_write now treats primary as a boolean value (as of the typebounds patch). A while back we made primary not necessarily a boolean in the module case where an alias had a value already and we needed to keep track of what the primary value was. The typebounds patch combined multiple fields into a 'properties' bitmap, which includes primary, so the value is now lost. We can change the module format to keep the primary field around, this particular piece of code is getting increasingly more confusing though (write.c:970)
diff --git a/checkpolicy/policy_define.c b/checkpolicy/policy_define.c
index 25b06c1..8c04767 100644
char *id; type_datum_t *aliasdatum = NULL; int ret; + uint32_t val; while ((id = queue_remove(id_queue))) { if (id_has_dot(id)) { free(id); @@ -1000,7 +1001,7 @@ static int add_aliases_to_type(type_datum_t * type) aliasdatum->s.value = type->s.value; ret = declare_symbol(SYM_TYPES, id, aliasdatum, - NULL, &aliasdatum->s.value); + &val, &aliasdatum->s.value); switch (ret) { case -3:{ yyerror("Out of memory!"); @@ -1017,6 +1018,17 @@ static int add_aliases_to_type(type_datum_t * type) } case 0: case 1:{ + /* ret == 1 means the alias was required and therefore already + * has a value. Set it up as an alias with a different primary. */ + type_datum_destroy(aliasdatum); + free(aliasdatum); + + aliasdatum = hashtab_search(policydbp->symtab[SYM_TYPES].table, id); + assert(aliasdatum); + aliasdatum->primary = type->s.value; + aliasdatum->flavor = TYPE_ALIAS; + + free(id); break; } default:{ -- This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with the words "unsubscribe selinux" without quotes as the message.Received on Sun 16 Nov 2008 - 19:00:12 EST |
|
Date Posted: Jan 15, 2009 | Last Modified: Jan 15, 2009 | Last Reviewed: Jan 15, 2009 |