>>>> For example, ebitmap_netlbl_export() when NetLabel is not enabled is
>>>> defined as explicitly inlined function which always returns -ENOMEM,
>>>> however, these are also declarations of function when NetLabel is enabled.
>>> Ah, never mind - as these are defined in the header file, they can stay
>>> static inline.
>> OK. I'll submit a patch to clean up non-stub static inline functions
>> next to this patch.

Sorry, I might misread your suggestion.

>>> Ok, looks reasonable.  Please run it through ./scripts/checkpatch.pl and
>>> fix up the minor issues it reports, then post a clean message with a
>>> suitable description and the patch inline.
>> What is your stance about warnings for "line over 80 characters" ?
>> To resolve all of them makes harder to read source code, so I'm ignoring
>> them in the attached version.
>> Rest of warnings except for them are removed.

I'm preparing another version of patch which does not contain any "line over 80 characters" warning. Please wait for a while.

> Need to make a fresh posting with appropriate subject line, text
> description of the patch, Signed-off-by, diffstat -p1 output, inlined
> patch. No residue from prior replies.

OK, the following part is a fresh patch. Received on Wed 26 Sep 2007 - 01:52:02 EDT