Opened 5 days ago
Closed 3 days ago
#30097 closed defect (bug) (fixed)
Unnecessary wildcard query when upgrading sites on a network
Reported by: | jeremyfelt | Owned by: | jeremyfelt |
---|---|---|---|
Milestone: | 4.1 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Networks and Sites | Keywords: | good-first-bug has-patch |
Focuses: | multisite | Cc: |
Description
From #24922
In wp-admin/network/upgrade.php, we use SELECT * FROM rather than SELECT blog_id FROM, even though blog_id is the only field used after the query.
Attachments (1)
Change History (4)
comment:2 jeremyfelt — 3 days ago
- Milestone changed from Future Release to 4.1
- Owner set to jeremyfelt
- Status changed from new to accepted
Thanks for the patch @marcosf! I tested this as well and everything's working properly.
Two tips for future patches - create the patch file from the repository root as this makes it easier to apply. Also, watch the diff for any change in whitespace.
comment:3 jeremyfelt — 3 days ago
- Resolution set to fixed
- Status changed from accepted to closed
In 30029:
Note: See
TracTickets for help on using
tickets.
I've changed the "SELECT *" to "SELECT blog_id" and tested the upgrade. The upgrade was working fine after applying the patch/change. I also double checked and did not find anything else that's needed by the upgrade script besides the blog id.