Changeset 30042

Timestamp:

10/28/14 14:56:33 (41 hours ago)

Author:

boonebgorges

Message:

Allow 'slug' param of get_terms() to accept an array.

Props jfarthing84, dlh.
Fixes #23636.

Location:

trunk

Files:

• src/wp-includes/taxonomy.php (modified) (2 diffs)
• tests/phpunit/tests/term/getTerms.php (modified) (1 diff)

trunk/src/wp-includes/taxonomy.php

@@ -1595 +1595 @@
  *                                           term objects), 'ids' or 'names' (returns an array of integers
  *                                           or strings, respectively. Default 'all'.
- *     @type string       $slug              Slug to return term(s) for. Default empty.
+ *     @type string|array $slug              Optional. Slug(s) to return term(s) for. Default empty.
  *     @type bool         $hierarchical      Whether to include terms that have non-empty descendants (even
  *                                           if $hide_empty is set to true). Default true.
@@ -1805 +1805 @@
 
     if ( ! empty( $args['slug'] ) ) {
-        $slug = sanitize_title( $args['slug'] );
-        $where .= " AND t.slug = '$slug'";
+        if ( is_array( $args['slug'] ) ) {
+            $slug = array_map( 'sanitize_title', $args['slug'] );
+            $where .= " AND t.slug IN ('" . implode( "', '", $slug ) . "')";
+        } else {
+            $slug = sanitize_title( $args['slug'] );
+            $where .= " AND t.slug = '$slug'";
+        }
     }
 

trunk/tests/phpunit/tests/term/getTerms.php

@@ -353 +353 @@
     }
 
+    public function test_get_terms_by_slug() {
+        $t1 = $this->factory->tag->create( array( 'slug' => 'foo' ) );
+        $t2 = $this->factory->tag->create( array( 'slug' => 'bar' ) );
+
+        $found = get_terms( 'post_tag', array(
+            'hide_empty' => false,
+            'fields' => 'ids',
+            'slug' => 'foo',
+        ) );
+
+        $this->assertEquals( array( $t1 ), $found );
+    }
+
+    /**
+     * @ticket 23636
+     */
+    public function test_get_terms_by_multiple_slugs() {
+        $t1 = $this->factory->tag->create( array( 'slug' => 'foo' ) );
+        $t2 = $this->factory->tag->create( array( 'slug' => 'bar' ) );
+        $t3 = $this->factory->tag->create( array( 'slug' => 'barry' ) );
+
+        $found = get_terms( 'post_tag', array(
+            'hide_empty' => false,
+            'fields' => 'ids',
+            'slug' => array( 'foo', 'barry' )
+        ) );
+
+        $this->assertEquals( array( $t1, $t3 ), $found );
+    }
+
     public function test_get_terms_hierarchical_tax_hide_empty_false_fields_ids() {
         // Set up a clean taxonomy.