Opened 4 years ago
Closed 5 months ago
#15490 closed enhancement (fixed)
Preview oEmbed results when using the media modal to insert from URL
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | 4.0 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Media | Keywords: | has-patch |
Focuses: | Cc: |
Description
If you insert a video URL via the "Add media file from URL" popup, it should do the following:
- Determine whether the URL is oEmbed-able, and if so, insert the appropriate shortcode into the post.
- Create a corresponding attachment with something indicating that it's a video in the post_mime_type field (even though we're not really dealing with true MIME types). That way, we can query video attachments, agnostic of where the actual video file exists.
Attachments (5)
Change History (40)
comment:1
jtsternberg
— 21 months ago
- Cc justin@… added
comment:2
jtsternberg
— 21 months ago
A feature discussed in [IRC today]https://irclogs.wordpress.org/chanlog.php?channel=wordpress-dev&day=2013-01-31&sort=asc#m544868 that would be a nice addition: Showing a preview in the modal if an oembed url is added.
comment:3
helen
— 21 months ago
- Milestone changed from Future Release to 3.6
On the "Insert from URL" panel in the media modal:
nacin: so, A) detect oEmbed provider URLs, B) showing a preview of said video in the process, C) ensuring it gets inserted on its own line (force a line break) would complete this feature.
comment:4
jtsternberg
— 21 months ago
And one more reference link: [pre 3.6 post format overhaul user-testing]http://make.wordpress.org/ui/2013/01/31/have-made-it-through-the-second-round-of/
comment:5
follow-up:
↓ 6
jtsternberg
— 21 months ago
Should this same functionality apply to all supported and applicable oEmbed urls? i.e. Tweets, slideshare, polldaddy, etc. Or should this only apply to the traditional "media" types like video/audio?
comment:6
in reply to:
↑ 5
;
follow-ups:
↓ 7
↓ 9
DrewAPicture
— 21 months ago
Replying to jtsternberg:
Should this same functionality apply to all supported and applicable oEmbed urls? i.e. Tweets, slideshare, polldaddy, etc. Or should this only apply to the traditional "media" types like video/audio?
I feel like it would be a nice-to-have but may fall outside the scope of the ticket. Setting it up for video-only at least initially would be a good test case.
comment:7
in reply to:
↑ 6
;
follow-up:
↓ 10
helen
— 21 months ago
Replying to DrewAPicture:
I feel like it would be a nice-to-have but may fall outside the scope of the ticket.
Without actually functionally writing code, I can't promise this, but it seems to me that if we're already detecting if it's an oEmbed provider and retrieving the response, it doesn't matter whether it's video, audio, a tweet, or something else.
comment:8
jtsternberg
— 21 months ago
I implemented very similar functionality with Custom Metaboxes and Fields for WordPress and plan on using that as a base for incorporating to WP for this ticket, but if anyone wants to take a look at the code and take a stab at it before I get time, hopefully that will help point you in the right direction.
comment:9
in reply to:
↑ 6
jtsternberg
— 21 months ago
Replying to DrewAPicture:
Replying to jtsternberg:
Should this same functionality apply to all supported and applicable oEmbed urls? i.e. Tweets, slideshare, polldaddy, etc. Or should this only apply to the traditional "media" types like video/audio?
I feel like it would be a nice-to-have but may fall outside the scope of the ticket. Setting it up for video-only at least initially would be a good test case.
In the case of the CMB script, it really made no difference what the oembed content was, so I THINK we can do the same here.
jtsternberg
— 21 months ago
This successfully displays an oembed preview when an oembed url is detected. Still needs a proper nonce passed for the ajax action.
comment:10
in reply to:
↑ 7
jtsternberg
— 21 months ago
- Keywords has-patch added; needs-patch removed
As Helen pointed out in IRC, I think the next item to tackle is to remove the auto-linking when adding to a post via the media window. (which keeps the oEmbed from working on the front-end)
comment:11
gcorne
— 20 months ago
- Cc gregory@… added
comment:12
sabreuse
— 20 months ago
.2 is working nicely for me at embedding/previewing from the modal.
comment:13
helen
— 20 months ago
Two things I want to see, besides nonce and removing auto-linking when a valid response is returned:
- Testing usage of the Ajax action outside of the modal (looks like it'll work just fine, but would still like a test).
- Thoughts on how we can deal with caching the retrieved data to stay away from rate limit problems. Right now all oEmbed caches are dumped on pre_post_update and then re-requested, which already makes it extremely easy to hit, say, Twitter's rate limit of 150 per hour per IP, especially on shared hosting. May very well be outside the scope of this ticket itself, but would at least like to see what thoughts might be.
comment:14
helen
— 20 months ago
- Summary changed from Better Remote Video Insert to Preview oEmbed results when using the media modal to insert from URL
comment:15
DrewAPicture
— 20 months ago
- Cc xoodrew@… added
comment:16
ryan
— 18 months ago
- Milestone changed from 3.6 to Future Release
comment:17
taylorde
— 16 months ago
- Cc td@… added
comment:18
helen
— 10 months ago
#24762 was marked as a duplicate.
comment:19
helen
— 9 months ago
#22548 was marked as a duplicate.
comment:20
ircbot
— 9 months ago
This ticket was mentioned in IRC in #wordpress-ui by helen. View the logs.
comment:21
ircbot
— 8 months ago
This ticket was mentioned in IRC in #wordpress-dev by helen. View the logs.
comment:22
ircbot
— 6 months ago
This ticket was mentioned in IRC in #wordpress-dev by helen. View the logs.
wonderboymusic
— 6 months ago
comment:23
wonderboymusic
— 6 months ago
- Milestone changed from Future Release to 4.0
15490.3.diff refreshes the Backbone pieces and leans on [28358] for the auto-parsing of [embed] in TinyMCE
comment:24
jtsternberg
— 6 months ago
I'm thinking we should remove the width/height inputs from the 'embed-link-settings' template. It's not applicable to all oembed types and it's probably not worth adding an if/else/switch statement to determine if they should be conditionally added. Also those widths should default to the [$content_width](http://codex.wordpress.org/Content_Width) global.
Thoughts? I'll provide a diff in case we're in agreement.
jtsternberg
— 6 months ago
Removes width/height inputs, and improves the styling of the oEmbed items in responsive views.
comment:25
jtsternberg
— 6 months ago
Last diff also contains css improvements. I tested at a window width of 645px and tested these oEmbed endpoints:
- flickr
- videopress (videopress)
- wordpress.tv
- vimeo
- slideshare
- imgur
- youtube
comment:26
jtsternberg
— 6 months ago
One other thing I forgot to mention re: 15490.4.diff. I removed the width/height inputs from the template for reasons stated above, and on top of those, there was nothing written to handle the data entered in the width/height inputs.
comment:27
ircbot
— 6 months ago
This ticket was mentioned in IRC in #wordpress-dev by helen. View the logs.
comment:28
ircbot
— 6 months ago
This ticket was mentioned in IRC in #wordpress-dev by helen. View the logs.
comment:29
wonderboymusic
— 5 months ago
- Owner filosofo deleted
- Status changed from new to assigned
wonderboymusic
— 5 months ago
comment:30
wonderboymusic
— 5 months ago
15490.5.diff refreshes after [28580]
comment:31
wonderboymusic
— 5 months ago
In 28581:
comment:32
SergeyBiryukov
— 5 months ago
Is there a need for global $post in wp_ajax_send_link_to_editor()?
comment:33
wonderboymusic
— 5 months ago
$post is pre-existing. There are probably a bunch of places where it is imported and never used. I will scan.
comment:34
wonderboymusic
— 5 months ago
Yes, it is required. $post (the global) is set later on down the road, $wp_embed requires it. If it is removed, the preview is correct, but a link is inserted into the editor.
comment:35
wonderboymusic
— 5 months ago
- Resolution set to fixed
- Status changed from assigned to closed
We are showing preview now, there are other tickets that address specifics.
Related: #11552