move password hint text to a function

[convissor]

The password hint text, noted below, is hard coded in four places:

wp-admin/install.php
wp-admin/user-edit.php
wp-admin/user-new.php
wp-login.php

Hint: The password should be at least seven characters long. To make it stronger, use upper and lower case letters, numbers and symbols like ! " ? $ % ^ & ).

This approach is prone to mistakes when changes are made. In addition, plugins that want to override the text need to use the resource intensive and clumsy gettext filter.

Per nacin and westi, the attached patch moves the text to a function (wp_password_hint()) in wp-includes/user.php and adds a filter (password_hint).

It would probably make sense to mark the function as private (21243.2.diff​), similarly to _wp_get_user_contactmethods().

I like this.
Simple function and it has filterable text.

+1 for this. Refreshed patch.

clean, patch updated to 4.1

The minor grammar change in #26457 / r27246 "breaking" ​Login Security Solution reaffirms the need for this patch.

This ticket was mentioned in IRC in #wordpress-dev by DanielConvissor. ​View the logs.

The filter needs to be documented as per the ​documentation standards.

Add docblock for filter hook call. Fix @since on main function.

In 29962:

Move password hint text to a function. Add 'password_hint' filter.

props convissor.
fixes #21243.

Let's rename the function to _wp_get_password_hint(), for consistency with other functions like _wp_get_user_contactmethods() or _get_additional_user_keys().

Updated the function name for make consistency with other functions.

patch file with updated function name

Patch file with formatting

Replying to SergeyBiryukov:

Let's rename the function to _wp_get_password_hint(), for consistency with other functions like _wp_get_user_contactmethods() or _get_additional_user_keys().

Sergey,

why not use a shorter name _get_password_hint() ?

Replying to ramiy:

Replying to SergeyBiryukov:

Let's rename the function to _wp_get_password_hint(), for consistency with other functions like _wp_get_user_contactmethods() or _get_additional_user_keys().

Sergey,

why not use a shorter name _get_password_hint() ?

We can use this. It is based on our choice. Let me know, what is the issue with longer name of the function ?

In 30033:

Rename _wp_password_hint() to _wp_get_password_hint() to bring it inline with core terminology. Fixes #21243.